Switch schema sync summary API from detailed to basic mode#1791
Open
kmcginnes wants to merge 1 commit into
Open
Switch schema sync summary API from detailed to basic mode#1791kmcginnes wants to merge 1 commit into
kmcginnes wants to merge 1 commit into
Conversation
kmcginnes
force-pushed
the
switch-summary-api-to-basic-mode
branch
9 times, most recently
from
b0e1518 to
3ed615a
Compare
Basic mode returns all fields Graph Explorer uses (nodeLabels, edgeLabels, numNodes, numEdges) without the unused nodeStructures and edgeStructures. Also makes the proxy forward query params as-is instead of hardcoding mode=detailed. Removes broken lint-staged config from graph-explorer sub-package (referenced removed eslint; root config already handles linting). Closes #1789
kmcginnes
force-pushed
the
switch-summary-api-to-basic-mode
branch
from
3ed615a to
27c99e5
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| try { | ||
| const res = await fetch(url.href, options); | ||
| const res = await fetch(url.href, options); // lgtm[js/request-forgery] |
arseny-kostenko
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Schema Sync previously requested Neptune's summary API with
mode=detailed, which returnsnodeStructuresandedgeStructuresthat Graph Explorer never uses (they lack label association, so they can't map to GE's label-centric schema model). This switches tomode=basicwhich returns all the fields GE actually consumes:nodeLabels,edgeLabels,numNodes,numEdges.Additionally, the proxy server was hardcoding
?mode=detailedon all three summary endpoints instead of forwarding client query params. It now passesreq.urldirectly to the upstream URL resolver, which naturally includes any query string the client sent.How to read the changes:
app.ts(proxy) —resolveEndpointUrlrelaxed to accept leading slashes; summary handlers now just forwardreq.urlas-isgremlinExplorer.ts,openCypherExplorer.ts,sparqlExplorer.ts— one-line URL change each (detailed→basic)Validation
pnpm checkspasses (lint, format, types)pnpm testpasses (1709 tests including 8 new ones)Related Issues
Check List
pnpm checkspasses with no errors.pnpm testpasses with no failures.