Add PROXY_SERVER_ALLOWED_DB_ORIGINS to restrict proxy forwarding targets#1794
Open
kmcginnes wants to merge 2 commits into
Open
Add PROXY_SERVER_ALLOWED_DB_ORIGINS to restrict proxy forwarding targets#1794kmcginnes wants to merge 2 commits into
kmcginnes wants to merge 2 commits into
Conversation
Introduces an optional allowlist for database origins the proxy server will forward to, mitigating SSRF risk. Also refactors error handling with an HttpError base class and disables HTTP redirects on outbound requests.
arseny-kostenko
approved these changes
May 29, 2026
3d31717 to
568fd0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an optional
PROXY_SERVER_ALLOWED_DB_ORIGINSenv var that restricts which database origins the proxy server will forward requests to. When set (comma-separated origins likehttps://neptune:8182), the proxy rejects requests targeting unlisted origins with a 403. When unset, behavior is unchanged (fully permissive).Also:
HttpErrorbase class with optionaldetailsfor structured error responsesRequestValidationErrorextendHttpError(status 400, includeszodErrorin response)getStatusFromErrorhelper and the...errorspreadredirect: "error")docs/references/configuration.mdanddocs/references/security.mdReading order:
errors.ts→error-handler.ts→env.ts→allowed-db-origins.ts→app.ts(wiring) → docsValidation
pnpm checkspasses (lint, format, typecheck)HttpErrorhierarchy, env var parsing (valid/invalid/edge cases),assertAllowedDbOriginfunction (case normalization, port normalization, scheme enforcement, empty set rejection)Related Issues
Check List
pnpm checkspasses with no errors.pnpm testpasses with no failures.