Skip to content

chore: remove mock writeStatusAndHeaders shadowing in writer tests #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebsto merged 1 commit into from
Mar 4, 2026
Merged

chore: remove mock writeStatusAndHeaders shadowing in writer tests #657

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 0 additions & 44 deletions Tests/AWSLambdaRuntimeTests/LambdaResponseStreamWriter+HeadersTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,22 +542,6 @@ final class MockLambdaResponseStreamWriter: LambdaResponseStreamWriter {
private(set) var isFinished = false
private(set) var hasCustomHeaders = false

// Add a JSON string with separator for writeStatusAndHeaders
func writeStatusAndHeaders<Response: Encodable>(
_ response: Response,
encoder: (any LambdaOutputEncoder)? = nil
) async throws {
var buffer = ByteBuffer()
let jsonString = "{\"statusCode\":200,\"headers\":{\"Content-Type\":\"text/plain\"}}"
buffer.writeString(jsonString)

// Add null byte separator
let nullBytes: [UInt8] = [0, 0, 0, 0, 0, 0, 0, 0]
buffer.writeBytes(nullBytes)

try await self.write(buffer, hasCustomHeaders: true)
}

func write(_ buffer: ByteBuffer, hasCustomHeaders: Bool = false) async throws {
writtenBuffers.append(buffer)
self.hasCustomHeaders = hasCustomHeaders
Expand Down Expand Up @@ -587,15 +571,6 @@ final class FailingMockLambdaResponseStreamWriter: LambdaResponseStreamWriter {
self.failOnWriteCall = failOnWriteCall
}

func writeStatusAndHeaders<Response: Encodable>(
_ response: Response,
encoder: (any LambdaOutputEncoder)? = nil
) async throws {
var buffer = ByteBuffer()
buffer.writeString("{\"statusCode\":200}")
try await write(buffer, hasCustomHeaders: true)
}

func write(_ buffer: ByteBuffer, hasCustomHeaders: Bool = false) async throws {
writeCallCount += 1
self.hasCustomHeaders = hasCustomHeaders
Expand Down Expand Up @@ -698,15 +673,6 @@ final class TrackingLambdaResponseStreamWriter: LambdaResponseStreamWriter {
private(set) var isFinished = false
private(set) var hasCustomHeaders = false

func writeStatusAndHeaders<Response: Encodable>(
_ response: Response,
encoder: (any LambdaOutputEncoder)? = nil
) async throws {
var buffer = ByteBuffer()
buffer.writeString("{\"statusCode\":200}")
try await write(buffer, hasCustomHeaders: true)
}

func write(_ buffer: ByteBuffer, hasCustomHeaders: Bool = false) async throws {
writeCallCount += 1
self.hasCustomHeaders = hasCustomHeaders
Expand All @@ -733,16 +699,6 @@ final class CustomBehaviorLambdaResponseStreamWriter: LambdaResponseStreamWriter
private(set) var isFinished = false
private(set) var hasCustomHeaders = false

func writeStatusAndHeaders<Response: Encodable>(
_ response: Response,
encoder: (any LambdaOutputEncoder)? = nil
) async throws {
customBehaviorTriggered = true
var buffer = ByteBuffer()
buffer.writeString("{\"statusCode\":200}")
try await write(buffer, hasCustomHeaders: true)
}

func write(_ buffer: ByteBuffer, hasCustomHeaders: Bool = false) async throws {
// Trigger custom behavior on any write
customBehaviorTriggered = true
Expand Down