Skip to content

[BUGFIX] Properly resolve max tokens key for gemini #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
o-ba wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −1
Open

[BUGFIX] Properly resolve max tokens key for gemini #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Classes/Provider/SymfonyAi/SymfonyAiPlatformAdapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,10 +445,18 @@ private function buildOptions(string $model, int $maxTokens, float $temperature,
}

/**
* Resolve the max-tokens option key expected by a Symfony AI bridge based on the used bridge
* Resolve the max-tokens option key expected by a Symfony AI bridge.
*
* Each bridge keeps the option naming convention of its underlying API:
* - Gemini uses camelCase (Google REST API: "maxOutputTokens")
* - OpenAI / OpenResponses use snake_case "max_output_tokens"
* - Anthropic / Mistral / Ollama and most others use legacy "max_tokens"
*/
public static function resolveMaxTokensKey(string $factoryClass): string
{
if (str_contains($factoryClass, '\\Bridge\\Gemini\\')) {
return 'maxOutputTokens';
}
if (str_contains($factoryClass, '\\Bridge\\OpenAi\\')
|| str_contains($factoryClass, '\\Bridge\\OpenResponses\\')
) {
Expand Down
4 changes: 4 additions & 0 deletions Tests/Unit/Provider/SymfonyAi/SymfonyAiPlatformAdapterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ public static function maxTokensKeyProvider(): \Generator
'Symfony\\AI\\Platform\\Bridge\\OpenResponses\\PlatformFactory',
'max_output_tokens',
];
yield 'Gemini uses camelCase per Google REST API' => [
'Symfony\\AI\\Platform\\Bridge\\Gemini\\PlatformFactory',
'maxOutputTokens',
];
yield 'Anthropic Messages API' => [
'Symfony\\AI\\Platform\\Bridge\\Anthropic\\PlatformFactory',
'max_tokens',
Expand Down