-
Notifications
You must be signed in to change notification settings - Fork 0
Implement Clerk authentication with @wisc.edu and GitHub org restrict… #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
87f4ce8
Implement Clerk authentication with @wisc.edu and GitHub org restrict…
Fangrui-Zhang dbfd167
Add expo-modules-core as direct dependency for CI
Fangrui-Zhang c37120e
Update CI to allow expo-modules-core warning
Fangrui-Zhang c9420c9
Fix CI: Handle expo-doctor exit code properly
Fangrui-Zhang c1748f0
Fix Clerk imports: use @clerk/expo instead of @clerk/clerk-expo
Fangrui-Zhang 82deb8a
Add expo-web-browser dependency for Clerk OAuth
Fangrui-Zhang ff8109a
Fix OAuth authentication: use useOAuth hook and install expo-auth-ses…
Fangrui-Zhang 26faabb
Merge branch 'main' into authentication---clerk
sbasu107 2417588
Initial plan
Copilot 1adae81
feat: add platform-specific OAuth handling (web vs native)
Copilot 38f3c59
Added client-side verification for valid accounts
sbasu107 eede8d2
Patched redirect loop
sbasu107 e1b7890
Merge pull request #15 from badgerloop-software/copilot/sub-pr-12
sbasu107 98deae5
fix: hooks order in tabs layout, tablet quick action buttons, remove …
Fangrui-Zhang 92dfb61
Merge origin/main into authentication---clerk.
sbasu107 fbee547
Sync classic settings auth status across UI modes.
sbasu107 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
tokenCacheobject only implementsgetTokenandsaveToken, but the ClerkTokenCacheinterface also requires adeleteTokenmethod (used during sign-out). Without implementingdeleteToken, signing out may not properly clear cached tokens fromexpo-secure-store, potentially allowing stale tokens to persist.