feat(eslint-plugin): add rules to avoid low performance#118
Open
fannytavart wants to merge 12 commits intomainfrom
Open
feat(eslint-plugin): add rules to avoid low performance#118fannytavart wants to merge 12 commits intomainfrom
fannytavart wants to merge 12 commits intomainfrom
Conversation
Almouro
reviewed
Aug 19, 2024
Almouro
left a comment
Almouro
left a comment
There was a problem hiding this comment.
Cool sinon !
Je vais me charger de rajouter des explications plus précises
fannytavart
force-pushed
the
feat/create-performance-config
branch
from
956111b to
fcfc066
Compare
fannytavart
force-pushed
the
feat/create-performance-config
branch
4 times, most recently
from
8147b29 to
92d7a57
Compare
…react-navigation/stack in favor of @react-navigation/native-stack
fannytavart
force-pushed
the
feat/create-performance-config
branch
3 times, most recently
from
5d6b985 to
dc465fd
Compare
Almouro
suggested changes
Sep 5, 2024
| // This should trigger one error breaking custom FlatList import rule: | ||
| // @bam.tech/no-flatlist | ||
|
|
||
| import { FlatList } from "react-native"; |
There was a problem hiding this comment.
since we already got tests for all those rules, I'd vote for removing those example files, I think they add noise
What do you think @cyrilbo @matthieugicquel ?
packages/eslint-plugin/lib/rules/no-animated-without-native-driver.ts
Outdated
Show resolved
Hide resolved
fannytavart
force-pushed
the
feat/create-performance-config
branch
5 times, most recently
from
f2bd860 to
6c936ae
Compare
…to performance rules
…stom rule for rn svg to show a warning
…o prevent from overriding with the existing import rule
fannytavart
force-pushed
the
feat/create-performance-config
branch
from
6c936ae to
71645af
Compare
…k to prevent override with eslint import rule
…cused to prevent from override by import eslint rule
fannytavart
force-pushed
the
feat/create-performance-config
branch
from
71645af to
8368a20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.