chore: delete custom rule to await user event#94
Open
pierrezimmermannbam wants to merge 1 commit intomainfrom
Open
chore: delete custom rule to await user event#94pierrezimmermannbam wants to merge 1 commit intomainfrom
pierrezimmermannbam wants to merge 1 commit intomainfrom
Conversation
7cb7b58 to
9b70fe9
Compare
MattAgn
approved these changes
Nov 13, 2023
Contributor
|
On peut merger cette PR ? PS : la règle @bam.tech/await-user-event a une issue (et je ne sais pas où elle est déclaré et où on peut faire l'issue dessus (et s'il y en a vraiment besoin)) |
Contributor
Author
|
Après réflexion je sais pas si on veut la supprimer, je la retirerais du recommended mais ça peut être commode pour des projets sur lesquels l'adoption de no-floating-promises est un peu plus compliquée |
|
@pierrezimmermannbam on s'était pas dit que sinon les projets pouvaient appliquer la règle no-floating-promise que sur les tests ? |
Contributor
Author
|
Oui c'est une possibilité en effet, le seul désavantage c'est que ça nécessite un setup eslint un peu plus complexe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rule is now obsolete because the
@typescript-eslint/no-floating-promisesrule works for that use case