[Feature] init config #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkitlabs
commented
Oct 16, 2024
falcon/app.go
Outdated
Comment on lines
125
to
136
| var cfg Config | ||
| var err error | ||
| switch { | ||
| case customFilePath != "": | ||
| cfg, err = LoadConfig(customFilePath) // Initialize with CustomConfig if file is provided | ||
| if err != nil { | ||
| return fmt.Errorf("LoadConfig file %v error %v", customFilePath, err) | ||
| } | ||
| default: | ||
| cfg = DefaultConfig() // Initialize with DefaultConfig if no file is provided | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
- move the logic to below
os.Createpart, so that the code states clearly that first part is about creating a folder/file - prefer if/else over switch case
nkitlabs
commented
Oct 18, 2024
added 2 commits
October 18, 2024 13:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: Add init config & test
Implementation details
Please ensure the following requirements are met before submitting a pull request:
CHANGELOG_UNRELEASED.mdFiles changedtab in the Github PR explorer)