feat(flashblocks): add UnifiedReceiptBuilder for seamless deposit receipt handling #345
+172
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eipt handling Add a new UnifiedReceiptBuilder that handles both deposit and non-deposit transactions seamlessly without requiring error handling at the call site. The builder wraps OpRethReceiptBuilder and automatically handles the deposit receipt case internally, eliminating the need for callers to implement the try-catch pattern typically required when using build_receipt followed by build_deposit_receipt. Changes: - Add receipt_builder module with UnifiedReceiptBuilder - Update PendingStateBuilder to use UnifiedReceiptBuilder - Simplify execute_with_evm method by removing manual deposit handling - Remove receipt_builder parameter from PendingStateBuilder::new() Closes base#309
Collaborator
🟡 Heimdall Review Status
|
Removed wrapper around OpRethReceiptBuilder and implemented direct receipt building logic. This fixes type mismatches between OpTxEnvelope and OpTransactionSigned that prevented compilation. - Use direct OpTxType matching instead of build_receipt/build_deposit_receipt pattern - Accept ExecutionResult<E::HaltReason> for proper generic type handling - Remove unused alloy-op-evm dependency
refcell
reviewed
Jan 11, 2026
| input, | ||
| &mut self.l1_block_info, | ||
| ) | ||
| .unwrap() |
Contributor
There was a problem hiding this comment.
Can we properly bubble up an error here instead of using .unwrap()? We should have fixed this previously but if we're modifying this, let's cleanup past issues.
refcell
reviewed
Jan 11, 2026
| self.cumulative_gas_used, | ||
| self.pending_block.timestamp, | ||
| ) | ||
| .map_err(|_| ExecutionError::DepositAccountLoad)?; |
Contributor
There was a problem hiding this comment.
Let's implement From<ReceiptBuildError> for ExecutionError. This should let us remove the .map_err here and just use the ? operator.
So this would just become:
let receipt = self
.receipt_builder
.build(
&mut self.evm,
&transaction,
result,
&state,
self.cumulative_gas_used,
self.pending_block.timestamp,
)?;
refcell
reviewed
Jan 11, 2026
| evm: &mut E, | ||
| transaction: &Recovered<OpTxEnvelope>, | ||
| result: ExecutionResult<E::HaltReason>, | ||
| _state: &EvmState, |
Contributor
There was a problem hiding this comment.
Can we remove this argument if it's unused?
refcell
reviewed
Jan 11, 2026
Comment on lines
+137
to
+142
| #[test] | ||
| fn test_unified_receipt_builder_creation() { | ||
| let chain_spec = Arc::new(OpChainSpecBuilder::base_mainnet().build()); | ||
| let builder = UnifiedReceiptBuilder::new(chain_spec); | ||
| assert!(std::mem::size_of_val(&builder) > 0); | ||
| } |
Contributor
There was a problem hiding this comment.
Can we add some tests that cover the logic of the UnifiedReceiptBuilder? This test is effectively a no-op
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduces
UnifiedReceiptBuilder- a wrapper that handles both deposit and non-deposit transaction receipts seamlessly, eliminating the try-catch pattern required byOpReceiptBuilder.Changes
receipt_builder.rswithUnifiedReceiptBuilder<C>structbuild()method handles both tx types internallystate_builder.rs- removed ~40 lines of manual deposit handlingalloy-op-evmdependencyCloses #309