feat(metering): Add state root timing to bundle metering #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Measure and report time spent calculating state root separately from transaction execution, enabling better performance analysis: - Add MeterBundleOutput struct with state_root_time_us field - Calculate state root after transaction execution using merge_transitions - Track state root calculation time separately from total execution time - Update RPC to log state_root_time_us in metering response - Add meter_bundle_state_root_time_invariant test The state root is computed by calling hashed_post_state on the bundle and then state_root_with_updates on the state provider.
niran
force-pushed
the
niran/meter-state-root-timing
branch
from
fda8f6c to
c53ce7c
Compare
niran
force-pushed
the
niran/metering-test-harness
branch
from
8695f6f to
fa14653
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add timing measurement for state root calculation in bundle metering. This provides visibility into the I/O cost of computing state roots, which is critical for understanding the full execution costs of a given bundle.
Key changes:
MeterBundleOutputstruct to replace tuple return type with named fieldsstate_root_time_usfield to measure state root calculation time separatelytotal_time_usfield for overall metering time (includes tx execution + state root)hashed_post_stateandstate_root_with_updatesmeter_bundle_state_root_time_invarianttest to verify timing consistencyTest plan
cargo test -p base-reth-metering- all 20 tests passcargo +nightly fmt --all -- --check- passescargo +nightly clippy --all-targets --all-features -- -D warnings- passes