Skip to content

Conversation

@refcell
Copy link
Contributor

@refcell refcell commented Jan 13, 2026

Summary

Closes #413

Adds full tracing_subscriber initialization with support for stdout and file logging, multiple log formats (Full, Json, Pretty, Compact, Logfmt), and configurable file rotation. Refactors logging configuration into separate structs for better flexibility.

Context

Split out work from #395.

@refcell refcell self-assigned this Jan 13, 2026
@refcell refcell added K-enhancement Kind: New feature or request A-shared Area: shared crates labels Jan 13, 2026
@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 13, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

danyalprout
danyalprout previously approved these changes Jan 13, 2026
…ogging

Adds full tracing_subscriber initialization with support for stdout and
file logging, multiple log formats (Full, Json, Pretty, Compact, Logfmt),
and configurable file rotation. Refactors logging configuration into
separate structs for better flexibility.

- Add tracing.rs with LogConfig::init_tracing_subscriber() and LogfmtFormatter
- Add LogArgs CLI struct with BASE_* environment variable support
- Expand LogFormat with Pretty and Logfmt variants
- Add FileLogConfig, StdoutLogConfig, and LogConfig structs
- Update GlobalArgs to use alloy_chains::Chain for l2_chain_id
- Add comprehensive rstest-based unit tests (38 tests)
@refcell refcell requested a review from danyalprout January 13, 2026 16:33
@refcell refcell enabled auto-merge January 13, 2026 16:44
@refcell refcell added this pull request to the merge queue Jan 13, 2026
Merged via the queue into main with commit 8ebc15a Jan 13, 2026
29 checks passed
@refcell refcell deleted the feat/tracing-refactor branch January 13, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-shared Area: shared crates K-enhancement Kind: New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(cli-utils): Setup Tracing Utilities

4 participants