Skip to content

Conversation

@danyalprout
Copy link
Collaborator

Description

Migrate the FB State to the FB config so it can be accessed by other extensions that need it.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 13, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@danyalprout danyalprout requested a review from niran January 13, 2026 16:41
@danyalprout danyalprout added this to the v0.3.0 milestone Jan 13, 2026
@danyalprout
Copy link
Collaborator Author

Should simplify the setup in #387

@danyalprout danyalprout marked this pull request as ready for review January 13, 2026 16:42
Copy link
Contributor

@niran niran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So basically, we had a start() already to kick off the state processor that needs the provider in the first place, so just initialize at start instead of a separate initialization phase. Metering doesn't need to worry about starting the state processor since that's flashblocks' job, so it can just hold on to an Arc<FlashblocksState> and get the pending blocks whenever it needs to. Much better!

@danyalprout danyalprout added this pull request to the merge queue Jan 13, 2026
Merged via the queue into main with commit 15f13bf Jan 13, 2026
29 checks passed
@danyalprout danyalprout deleted the danyal/reorg-extension-setup branch January 13, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants