chore(builder): remove builder transaction logic #456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✅ Heimdall Review Status
|
danyalprout
added
the
F-do-not-merge
Builder transactions are not enabled and won't be enabled on the network, so this removes the entire feature including CLI args, payload building integration, and related test assertions.
…comments Remove unused _state_provider parameter from build_next_flashblock and update test comments to clearly explain gas/DA calculations after builder transaction removal.
danyalprout
force-pushed
the
danyal/remove-builder-txns
branch
from
75deddc to
b6f4c85
Compare
danyalprout
removed
the
F-do-not-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the builder transactions as they aren't used on Base. Fixes #442.
This still requires a bit more work on the testing setup.