feat: upgrade bridge to allow for transfer of all token assets#103
Open
feat: upgrade bridge to allow for transfer of all token assets#103
Conversation
chunter-cb
reviewed
Feb 11, 2026
| /// @param recipient The address that received the funds. | ||
| /// @param token The token address (Constants.ETHER for native ETH). | ||
| /// @param amount The amount withdrawn. | ||
| event EmergencyWithdrawal(address indexed recipient, address indexed token, uint256 amount); |
Contributor
There was a problem hiding this comment.
I think emergency seems like unplanned.
I think this should be like ChainOperatorExitWithdrawal or something.
Also probably good to not call this Portal but PortalWithChainOperatatorExit or similar
chunter-cb
reviewed
Feb 11, 2026
| amount = IERC20(token).balanceOf(address(this)); | ||
| if (amount > 0) { | ||
| (address gasToken,) = gasPayingToken(); | ||
| if (token == gasToken) { |
Contributor
There was a problem hiding this comment.
Probably a nit but seems like we should be doing this after the safe transfer?
Cant recall if safeTransfer reverts or returns a bool as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade the optimism portal contract to support withdrawal of all locked funds.