This repository was archived by the owner on Jan 12, 2026. It is now read-only.
Fix tdx-quote-provider shutdown signal handling on non-unix#42
Open
kinderjoypresents wants to merge 1 commit intobase:mainfrom
Open
Fix tdx-quote-provider shutdown signal handling on non-unix#42kinderjoypresents wants to merge 1 commit intobase:mainfrom
kinderjoypresents wants to merge 1 commit intobase:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
This change makes tdx-quote-provider shutdown handling cross-platform by gating Unix-only signal handling behind cfg(unix) and using a Ctrl+C-only fallback on non-Unix targets.
💡 Motivation and Context
tdx-quote-provider used tokio::signal::unix::* unconditionally in shutdown_signal(), which fails to compile on Windows.
This update prevents Windows builds from breaking while keeping SIGTERM/SIGINT handling on Unix.
✅ I have completed the following steps:
Run make lint
Run make test
Added tests (if applicable)
Notes: This is a platform compatibility fix; no new tests were added.