Fix Samba configuration for Samba 4.20.6 compatibility#15064
Closed
soaresden wants to merge 2 commits intobatocera-linux:masterfrom
Closed
Fix Samba configuration for Samba 4.20.6 compatibility#15064soaresden wants to merge 2 commits intobatocera-linux:masterfrom
soaresden wants to merge 2 commits intobatocera-linux:masterfrom
Conversation
## Description This PR fixes Samba network sharing on Batocera by updating the configuration to work with modern Samba versions (4.20.6). ## Issues Fixed - Samba mode was inactive despite service running - Connection failures due to deprecated SMB1 protocol negotiation - Configuration warnings from empty [nobody] share definition ## Changes - **Remove deprecated SMB1 protocol**: Replaced `client min protocol = NT1` with `min protocol = SMB2` and `max protocol = SMB3` - **Remove empty share definition**: Deleted the empty `[nobody]` section at end of smb.conf which caused warnings - Updated configuration comments to clarify SMB protocol settings ## Testing - Samba service starts without warnings - Network shares are accessible via `\\BATOCERA\share` - Guest access works as expected - Tested with Samba 4.20.6 ## Files Changed - `board/batocera/fsoverlay/etc/samba/smb.conf` ## Checklist - [x] Configuration tested and working - [x] No breaking changes for existing users - [x] Maintains backward compatibility with share access
Contributor
I have my doubts If you do such changes then please add them also to changelog. Several NAS systems just use SMB1 (yes unsecure.....) but give users a chance to reconfigure the systems by announcing this. |
Fix Samba configuration for Samba 4.20.6 compatibility - Add comments and fallback option for users with legacy SMB1-only systems - Update changelog with breaking change note This change improves security and compatibility with newer Samba versions while allowing users with old NAS systems to revert to SMB1 if needed.
Contributor
|
Just read your hint. I see issues here...
|
Collaborator
|
samba 4.23.4 works fine here... it's unclear what you're trying to fix. |
Author
|
Hi,
I don't know, but on my side (RP5) batocera didn't run correctly samba.
I don't know if it's specific or not (didn't dig into code) but I had to
run the restart cmd in a custom.sh script to be able to access it
For the compatibility, SMB1 is quite old now, it's clearly unsafe
Le mar. 6 janv. 2026 à 12:31, Daniel Martin ***@***.***> a
écrit :
… *dmanlfc* left a comment (batocera-linux/batocera.linux#15064)
<#15064 (comment)>
samba 4.23.4 works fine here... it's unclear what you're trying to fix.
the nt1 compatibility has been there for 5 years. why would we restrict it?
—
Reply to this email directly, view it on GitHub
<#15064 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AM53EGQNNOBYNH2H7GO6OKL4FOMJ7AVCNFSM6AAAAACQUMAUB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOMJUGM3DGNRZHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Cordialement
________________________________________________________
**
*SOARES Denis*
tel: +33 6 80 89 92 11
e: ***@***.***
linkedin : https://www.linkedin.com/in/soaresden/
<https://www.linkedin.com/in/soaresden/>
________________________________________________________
|
Collaborator
|
we are not worried about security... obviously... it was set to provide the widest range of compatibility at the time. as crcerror pointed out legacy systems will need it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes Samba network sharing on Batocera by updating the configuration to work with modern Samba versions (4.20.6).
Issues Fixed
Changes
client min protocol = NT1withmin protocol = SMB2andmax protocol = SMB3[nobody]section at end of smb.conf which caused warningsTesting
\\BATOCERA\shareFiles Changed
board/batocera/fsoverlay/etc/samba/smb.confChecklist