-
Notifications
You must be signed in to change notification settings - Fork 145
Fix layering_check with path stripping and textual_hdrs #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix layering_check with path stripping and textual_hdrs #527
Conversation
Previously textual_hdrs paths were eagerly fetched which breaks path stripping. This wires these headers up separately to treat them like hdrs. Fixes bazelbuild/bazel#27718
|
i chose to split these out from |
| continue | ||
| add_header(path = header.path, visibility = "", can_compile = False) | ||
| added_paths.add(header.path) | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that the core difference is below the paths are already strings, where here we are processing file objects in a context where their paths can be stripped by bazel
fmeum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
Cc @c-mita as the original author
1 similar comment
|
Need to run through a few rounds of presubmit testing to make sure the previous failures don't show up again. thanks for the ping. |
|
thanks! |
Previously textual_hdrs paths were eagerly fetched which breaks path
stripping. This wires these headers up separately to treat them like
hdrs.
Fixes bazelbuild/bazel#27718