Add local_includes to cc_library / cc_binary #556
+109
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new attribute solves one of the longstanding annoyances with private include paths for third party projects. Today users often hardcode `-Iexternal/something` or come up with some complicated workarounds with custom rules vending make variables or `implementation_deps` This attribute is named after, and has the same semantics, as `defines` vs `local_defines`. These paths are only used in the context of the rule that they are on. Fixes bazelbuild/bazel#16472
keith
requested review from
armandomontanez,
c-mita,
comius,
hvadehra,
pzembrod and
trybka
as code owners
fmeum
approved these changes
Dec 20, 2025
| "includes": "Returns the set of search paths (as strings) for header files referenced " + | ||
| "both by angle bracket and quotes. Usually passed with -I.", | ||
| "local_includes": "Returns the set of search paths (as strings) for header files referenced " + | ||
| "both by angle bracket and quotes. Usually passed with -I.", |
Collaborator
There was a problem hiding this comment.
Add a note about propagation, similar to defines/local_defines below.
| <code>-I path_to_package/include_entry</code>. | ||
| Unlike <a href="#cc_binary.includes">INCLUDES</a>, these flags are added for | ||
| this rule and not added to every rule that depends on it. |
Collaborator
There was a problem hiding this comment.
Suggested change
| this rule and not added to every rule that depends on it. | |
| this target and not added to every target that depends on it. |
Collaborator
|
This also fixes bazelbuild/bazel#24144 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new attribute solves one of the longstanding annoyances with
private include paths for third party projects. Today users often
hardcode
-Iexternal/somethingor come up with some complicatedworkarounds with custom rules vending make variables or
implementation_depsThis attribute is named after, and has the same semantics, as
definesvs
local_defines. These paths are only used in the context of the rulethat they are on.
Fixes bazelbuild/bazel#16472