Skip to content

Conversation

@bbopen
Copy link
Owner

@bbopen bbopen commented Jan 15, 2026

Adds a single CI job (CI/required) that depends on all PR-critical jobs and fails if any of them fail. This lets us require one check in branch protection so auto-merge cannot merge while checks are still running.

@coderabbitai
Copy link

coderabbitai bot commented Jan 15, 2026

📝 Walkthrough

Walkthrough

Introduces a new "required" CI job that aggregates status from multiple dependent workflow jobs (lint, test, python-suite-core, python-suite-data, living-app, os, bun) and enforces collective success. Updates contribution guidelines to reference the new required CI check before merging.

Changes

Cohort / File(s) Summary
CI Workflow Enhancement
.github/workflows/ci.yml
Adds new "required" job that depends on 7 existing jobs, runs a result aggregation script, emits GitHub Actions errors for non-success statuses, and exits with failure if issues detected. Job skips on schedule triggers.
Documentation Update
CONTRIBUTING.md
Adds contributor instruction to wait for CI to turn green (including CI/required) and CodeRabbit completion before resolving review threads.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A guardian job now stands so tall,
Gathering results from one and all,
No merge shall pass, no PR succeed,
Until all checks agree indeed! ✅

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore(ci): add required aggregate check' directly and clearly describes the main change: adding a required aggregate CI check job.
Description check ✅ Passed The description clearly explains the purpose of the changes: adding a CI/required job that aggregates results of critical jobs for branch protection enforcement.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.



📜 Recent review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2fac16a and afe2918.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • CONTRIBUTING.md
🔇 Additional comments (2)
CONTRIBUTING.md (1)

18-18: LGTM!

Clear guidance for contributors that aligns with the new CI/required aggregate check being added to the workflow.

.github/workflows/ci.yml (1)

248-270: Well-structured aggregate check job.

The implementation correctly:

  • Uses always() to ensure execution regardless of upstream failures
  • Excludes schedule runs to match the dependent jobs' conditions
  • Checks for explicit success status, catching failures, cancellations, and skipped jobs

For matrix jobs (test, python-suite-core, os, bun), GitHub Actions aggregates results—if any matrix leg fails, needs.<job>.result will be failure, so this works as expected.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@bbopen bbopen merged commit a2f5540 into main Jan 15, 2026
20 checks passed
@bbopen bbopen deleted the chore/ci-required-gate branch January 15, 2026 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants