Conversation
- http+redis registerer and proxy client finished - golangci setup
kbats183
reviewed
Jul 29, 2022
api/proto/mux.proto
Outdated
|
|
||
| // Update is a single update received by the proxy, passed as the actual stringified update object. | ||
| message Update { | ||
| bytes json = 1; |
Member
There was a problem hiding this comment.
Why json is bytes? Won't this be a problem for sterilization in other languages?
| package services | ||
|
|
||
| // Allowlist specifies values that are explicitly allowed to be used | ||
| type Allowlist interface { |
Member
There was a problem hiding this comment.
Why Allowlist instead of AllowList
Author
There was a problem hiding this comment.
Allowlist это одно слово, а не несколько
internal/services/registrar.go
Outdated
| client genproto.MultiplexerServiceClient | ||
| } | ||
|
|
||
| func (r *gRPCRegistrar) tryRegister(ctx context.Context, request *genproto.RegisterRequest, updatech chan tgbotapi.Update) *svcError { |
Member
There was a problem hiding this comment.
"updatech" very strage for me, looks like abobich)
May be updateCh or updateChan?
| @@ -0,0 +1,151 @@ | |||
| package auth | |||
Member
There was a problem hiding this comment.
I not understand what is, may be ok
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.