Adapted tls to support custom certificate types.#2165
Closed
xipki wants to merge 2 commits intobcgit:mainfrom
Closed
Adapted tls to support custom certificate types.#2165xipki wants to merge 2 commits intobcgit:mainfrom
xipki wants to merge 2 commits intobcgit:mainfrom
Conversation
This adaption allows one to support new certificate type, e.g. the C509 certificate, without modifying the bouncycastle classes.
Contributor
Author
|
@peterdettman Hi Peter, could you please check this PR? We need this PR to demonstrate the integration of C509 certificates in the IETF COSE group. |
Contributor
Author
|
@gselander @emanjon Here the PR. |
Collaborator
|
Apologies for the long delay, this is now merged, thanks. Note that I changed the new There is other work pending around the server negotiation of certificate type (and auto-support for RawPublicKey when an X509 certificate is present); I will try to preserve flexibility around declared TlsCrypto support. |
Contributor
Author
|
Thank you. Do you plan to add changes in this PR also to bc-lts-java and the fips variant? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adaption allows one to support new certificate type, e.g. the C509 certificate (https://datatracker.ietf.org/doc/draft-ietf-cose-cbor-encoded-cert/), without modifying the bouncycastle classes.