Always add exception cause (first PR)#2250
Open
hendrikebbers wants to merge 2 commits intobcgit:mainfrom
Open
Conversation
Contributor
|
The constructor in use was not added till Java 5, we still support Java 4. If you use org.bouncycastle.util.Exceptions.illegalArgumentException() you'll get the effect you want as well as maintaining the compatibility we need to support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on #2239
The PR does not fix the issue but only changes some first places. Once the PR is merged I will continue by creating PRs for each module.