feat/aligment-mode

[wyzula-jan]

Description

Add alignment mode to the Waveform widget.

This introduces a new toolbar action that opens a dedicated alignment panel with:

• embedded PositionerControlLine bound to the active x-axis positioner
• embedded compact LMFitDialog showing existing DAP fits
• Move action for fitted center
• draggable target position line with Move To Target
• live plot indicators for current motor position and target position
• warning/status pill when the x axis is not a positioner or no DAP curve is available

The implementation adds dedicated alignment panel/controller utilities and wires them into Waveform. It also updates the compact LMFit dialog sizing so it embeds cleanly in the panel.

Related Issues

• closes [AlignmentMode]: Positioner Fine Tuning #1104

Type of Change

• Add Waveform alignment mode UI and plot interaction
• Add unit coverage for alignment panel, controller, and waveform integration

How to test

• Open Waveform widget in the main app
• Setup some curve with DAP curve
• Click on the toolbar icon to activate alignment panel
• Check fit parameters, use Move on center, activate target line, drag it, and move using Move To Target
• Tweak the motor with the embedded positioner box and verify the current-position indicator follows
• Remove the DAP curve or set the x mode to index / timestamp; the warning label should appear with instruction what to do to be able to use panel again

Additional Comments

Light-mode colors could still be tuned further; current readability is improved but could use another pass.

[codecov]

Codecov Report

❌ Patch coverage is 87.95918% with 59 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...dgets/plots/waveform/utils/alignment_controller.py	88.39%	14 Missing and 12 partials ⚠️
bec_widgets/widgets/plots/waveform/waveform.py	81.98%	10 Missing and 10 partials ⚠️
...ts/widgets/plots/waveform/utils/alignment_panel.py	90.84%	11 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

[Copilot]

Pull request overview

This PR introduces an “alignment mode” for the Waveform plot widget, adding a compact alignment panel plus plot overlays to support positioner-based alignment and fit-driven moves.

Changes:

• Add alignment mode UI (toolbar toggle + top side panel) and wiring in Waveform.
• Introduce WaveformAlignmentPanel (embedded positioner control + compact LMFit + target controls) and WaveformAlignmentController (marker/target overlays + action forwarding).
• Add unit tests covering alignment mode behavior in Waveform, plus dedicated tests for the panel and controller; adjust LMFit compact dialog sizing behavior.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/unit_tests/test_waveform.py	Adds integration-style tests for alignment mode toggling, positioner resolution, overlays, and DAP interactions.
tests/unit_tests/test_alignment_panel.py	Adds unit tests validating alignment panel signal forwarding and fit-action filtering.
tests/unit_tests/test_alignment_controller.py	Adds unit tests for controller overlay lifecycle, target bounds behavior, and move request emissions.
bec_widgets/widgets/plots/waveform/waveform.py	Wires alignment mode into Waveform (toolbar bundle, side panel, context building, move handling, lifecycle hooks).
bec_widgets/widgets/plots/waveform/utils/alignment_panel.py	New compact alignment panel widget (positioner control, compact LMFit, target controls, theme styling).
bec_widgets/widgets/plots/waveform/utils/alignment_controller.py	New controller managing plot overlays and synchronizing panel state/actions.
bec_widgets/widgets/dap/lmfit_dialog/lmfit_dialog.py	Improves size policies for the compact LMFit dialog when embedded.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.