Added ability to set the viewport and associated options for screenshots#8
Open
kgf1980 wants to merge 1 commit intobedrockio:mainfrom
Open
Added ability to set the viewport and associated options for screenshots#8kgf1980 wants to merge 1 commit intobedrockio:mainfrom
kgf1980 wants to merge 1 commit intobedrockio:mainfrom
Conversation
…ing a screenshot using the Puppeteer Page.setVIewport() method
Spacetown
added a commit
to Spacetown/gcovr
that referenced
this pull request
Dec 13, 2025
For correct screenshot we need to set the viewport. The PR bedrockio/export-html#8 for the container is still not merged, therefore we do the patch before building it.
Spacetown
added a commit
to Spacetown/gcovr
that referenced
this pull request
Dec 13, 2025
For correct screenshot we need to set the viewport. The PR bedrockio/export-html#8 for the container is still not merged, therefore we do the patch before building it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've created a PR which exposes the "fromSurface" screenshot option, as well as adding the ability to specify the viewport to use when creating a screenshot - when requesting a specific viewport size you also need to set fullPage to false (perhaps this should automatically happen if viewport options are provided?)
Example usage: