fix: handle object form of themoviedb_id from Fribb data#927
Open
Arlind-dev wants to merge 1 commit into
Open
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fribb/anime-listsnow shipsthemoviedb_idas an object ({tv?: number, movie?: number}) for entries that have a TMDB match — 8,381 of the current 42,142 entries.formatEntrystill passes the value straight intohandleBadValues, so the object reaches the SQLite bind step and crashes:The crash happens during the initial DB rebuild, so the container never reaches a serving state.
Fix: extract
themoviedb_id.tv ?? themoviedb_id.moviewhen it's an object before handing it tohandleBadValues. Type widened accordingly.Test plan
/api/v2/ids?source=anidb&id=12665returnsthemoviedb: 73223.