Generate Model Function GetAll filters fix#813
Open
cdavid14 wants to merge 1 commit intobeego:developfrom
Open
Generate Model Function GetAll filters fix#813cdavid14 wants to merge 1 commit intobeego:developfrom
cdavid14 wants to merge 1 commit intobeego:developfrom
Conversation
cdavid14
commented
Jan 19, 2022
- If you use filter expr "isnull" you should use a boolean value, as the filters and values are queried as a map[string]string object, then i added a if condition to fix this
- If you use filter expr "in" you should pass a array of content splitted by comma, so i've just splitted the string using this delimiter and passed as arguments on Filter function.
Author
|
@flycash please review :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.