Skip to content

fix(core): warn when composeSimple receives modifiers from different … #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
veged merged 1 commit into from
Feb 18, 2026
Merged

fix(core): warn when composeSimple receives modifiers from different … #633

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/core/core.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,19 @@ export type Composition<T> = <U extends ComponentType<any>>(

function composeSimple(mods: any[]) {
const { __blockName } = mods[0]

for (const mod of mods) {
if (mod.__blockName !== __blockName) {
console.error(
new Error(
'[bem-react] composeSimple: all modifiers must belong to the same block. '
+ `Expected "${__blockName}", got "${mod.__blockName}" for modifier "${mod.__mod}". `
+ 'The modifier will be applied incorrectly.',
),
)
}
}

const allMods: Record<string, (string | boolean)[]> = {}
const allModsPassProps: Record<string, boolean[]> = {}

Expand Down