Conversation
ClausKlein
requested review from
camio,
dietmarkuehl and
neatudarius
as code owners
|
@dietmarkuehl No one os the examples compiles after updating? and
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
| FetchContent_Declare( | ||
| execution | ||
| # SOURCE_DIR ${CMAKE_SOURCE_DIR}/../execution | ||
| # FETCHCONTENT_SOURCE_DIR_EXECUTION ${CMAKE_SOURCE_DIR}/../execution | ||
| GIT_REPOSITORY https://github.com/bemanproject/execution | ||
| GIT_TAG c587808 | ||
| GIT_TAG 66295d5 | ||
| SYSTEM | ||
| FIND_PACKAGE_ARGS | ||
| 0.2.0 | ||
| EXACT | ||
| NAMES | ||
| beman.execution | ||
| COMPONENTS | ||
| execution_headers | ||
| ) | ||
| FetchContent_MakeAvailable(execution) |
There was a problem hiding this comment.
I would not list this here, the direct dependency is only task.
There was a problem hiding this comment.
That's an interesting question: when including C++ headers, depending on indirect includes is frowned upon, at least in the world I'm in. net certainly uses both beman.execution and beman.task directly. However, since there are [potentially] version numbers referenced which may deviate, there is an obvious problem when.
In the end, I don't have much of an opinion on that.
| # NOTE: this must be done before tests! CK | ||
| include(./cmake/beman-install-library.cmake) | ||
| beman_install_library(${PROJECT_NAME} TARGETS beman.net_headers | ||
| DEPENDENCIES [===[beman.task 0.2.0 EXACT]===] |
There was a problem hiding this comment.
see my comment above.
| # function!** | ||
| # | ||
| # **Only header files contained in a `PUBLIC FILE_SET TYPE HEADERS` will be | ||
| # install with this function!** |
There was a problem hiding this comment.
| # install with this function!** | |
| # installed with this function!** |
| FetchContent_Declare( | ||
| execution | ||
| # SOURCE_DIR ${CMAKE_SOURCE_DIR}/../execution | ||
| # FETCHCONTENT_SOURCE_DIR_EXECUTION ${CMAKE_SOURCE_DIR}/../execution | ||
| GIT_REPOSITORY https://github.com/bemanproject/execution | ||
| GIT_TAG c587808 | ||
| GIT_TAG 66295d5 | ||
| SYSTEM | ||
| FIND_PACKAGE_ARGS | ||
| 0.2.0 | ||
| EXACT | ||
| NAMES | ||
| beman.execution | ||
| COMPONENTS | ||
| execution_headers | ||
| ) | ||
| FetchContent_MakeAvailable(execution) |
There was a problem hiding this comment.
That's an interesting question: when including C++ headers, depending on indirect includes is frowned upon, at least in the world I'm in. net certainly uses both beman.execution and beman.task directly. However, since there are [potentially] version numbers referenced which may deviate, there is an obvious problem when.
In the end, I don't have much of an opinion on that.
3 participants
This fix Install for #24