This repository was archived by the owner on Jan 1, 2025. It is now read-only.
Place display name between quotes after decoding.#71
Open
Kermer wants to merge 2 commits intobertjohnson:masterfrom
Open
Place display name between quotes after decoding.#71Kermer wants to merge 2 commits intobertjohnson:masterfrom
Kermer wants to merge 2 commits intobertjohnson:masterfrom
Conversation
|
This patch is also wrong. You can't just put quotes around the content of each decoded blob in the output string. What if you have something like this? You might end up with: You're also removing any single and double quote characters from the decoded output which is not a good idea because they may be significant. Remember: the idea is that the resulting DisplayName of the parsed address should be identical to what the user typed in the sending client (WYSIWYG). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #70