Convert to TypeScript #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atd-schubert
commented
Dec 20, 2018
| "our:setup:npm": "npm install", | ||
| "our:clean": "rm -Rf ./docs ./es2015 ./es5 ./out", | ||
| "our:compile": "npm run our:compile:es2015", | ||
| "our:compile": "npm run transpile && npm run our:compile:es2015", |
Author
There was a problem hiding this comment.
All the our:* tasks are not tested by me!
| if (this._domain) { | ||
| this._domain.run(this.onStep.bind(this, message)); | ||
| } else { | ||
| this.onStep(message); |
Author
There was a problem hiding this comment.
Was here a bug? I added message as parameter here.
| return this; | ||
| } | ||
|
|
||
| protected destroy(next?: () => void) { |
Author
There was a problem hiding this comment.
Can somebody confirm that protected and private is assigned correctly?
| "tabs" | ||
| ], | ||
| "variable-name": [ | ||
| false |
Author
There was a problem hiding this comment.
I don't want to change the private API, so I allowed undescore (_) prefixes for private variables... But I can also change this...
Member
|
@atd-schubert I've sent you an invite to the Bevry code team, so you will have write access for this, as I am too preoccupied with other things. Reach out via https://bevry.me/discord/dev for an orientation or if you need any help with following the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7