Recommend changing function names#30
Open
madpink wants to merge 4 commits into
Open
Conversation
To prevent confusion/problems with the built-in JSONToArray and ArrayToJSON functions, I recommend adding "fast." before the names
To prevent confusion/problems with the built-in JSONToArray and ArrayToJSON functions, I recommend adding "fast." before the names
Changed main function name to not conflict with built-in library Sorted numeric array to correct JSON order array Added option to include blank placeholders in JSON array Changed scope of some variables/constants Added "null" text placeholder
Contributor
Author
|
Changed main function name to not conflict with built-in library |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since JSONToArray and ArrayToJSON are now built-in functions, I recommend changing the function names in fastJSON. I Prefixed the commands with "fast.":
fast.arrayToJson
fast.jsonToArray