Add gen adapter parameter to validateEveryToJSON#39
Open
avandecreme wants to merge 1 commit intobiocad:masterfrom
Open
Add gen adapter parameter to validateEveryToJSON#39avandecreme wants to merge 1 commit intobiocad:masterfrom
avandecreme wants to merge 1 commit intobiocad:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am currently working with an API which can have very nested types with arrays.
So using the default
Arbitraryinstance make the tests very slow.The solution is to call QuickCheck's
resizefunction with a low number. After all we are only checking the shape of the data, its size shouldn't matter.So in this PR I add
validateEveryToJSON'andvalidateEveryToJSONWithPatternChecker'which allow to pass a function to adapt the generator.