Open
Conversation
Only call pfnSetPixelFast when the computed font color differs from the background (iBG). This prevents drawing transparent/background pixels, avoiding overlap artifacts (e.g., with italic fonts) and reducing unnecessary pixel writes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @bitbank2 - this library is amazing and I am loving your work
I am using your library to control a LILYGO T5 E-Paper S3 Pro and I'm displaying some anti aliased text
I've encountered some small visual bugs and I'm also hoping to add dark mode support
Hopefully this PR helps to explain what the problem is and possible fixes
bbepWriteStringCustom,src/bb_ep_gfx.inl).bbepWriteStringCustom,src/bb_ep_gfx.inl).bbepWriteStringCustom,src/bb_ep_gfx.inl).bbepWriteStringCustom,src/bb_ep_gfx.inl).Before - note the vertical edges and the clipped italic text

Before - white text on black background

After - fixed vertical edges and clipped text

After - inverted grays if background is black
