Fixed display corruption in smoothUpdate on M5Paper S3#26
Open
mikaryyn wants to merge 1 commit intobitbank2:mainfrom
Open
Fixed display corruption in smoothUpdate on M5Paper S3#26mikaryyn wants to merge 1 commit intobitbank2:mainfrom
mikaryyn wants to merge 1 commit intobitbank2:mainfrom
Conversation
…olor == BBEP_WHITE` check.
Author
|
I used this simple test program: extern "C" void app_main(void)
{
epd.initPanel(BB_PANEL_M5PAPERS3);
epd.setMode(BB_MODE_4BPP);
epd.clearWhite();
epd.fillScreen(epd.getMode() == BB_MODE_4BPP ? 0xF : (epd.getMode() == BB_MODE_2BPP ? 3 : BBEP_WHITE));
epd.drawLine(0, 0, epd.width() - 1, epd.height() - 1, BBEP_BLACK);
epd.drawLine(epd.width() - 1, 0, 0, epd.height() - 1, BBEP_BLACK);
epd.smoothUpdate(true, BBEP_WHITE);
while (true) { vTaskDelay(pdMS_TO_TICKS(1000)); }
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using smoothUpdate on M5Paper S3 causes display corruption. It is easy to see in the photos I have attached; first is before the fix and second is after. The changes are very small, but I cannot say if this will work also on other panels.
Line 1759 is simple, there is an error in the comparison. Other two changes are a bit more difficult for me to explain. It changes ordering between DMA transfers and row-advance (ROW_STEP). Apparently the old ordering could interfere with the previous DMA transfer which is still ongoing and corrupt the display. First change is for the 1bpp path and second is for the 4bpp.