Add PKCS11 token support with tests and documentation#780
Closed
rajanarahul93 wants to merge 1 commit intobitcoin-core:masterfrom
rajanarahul93:feature/pkcs11-token-support
Closed
Add PKCS11 token support with tests and documentation#780rajanarahul93 wants to merge 1 commit intobitcoin-core:masterfrom rajanarahul93:feature/pkcs11-token-support
rajanarahul93 wants to merge 1 commit intobitcoin-core:masterfrom
rajanarahul93:feature/pkcs11-token-support
Conversation
|
@rajanarahul93 any good reason why this PR was closed ? It's a real add up ! |
Author
|
@embetrix Thanks for pointing that out! I closed it unintentionally when I deleted my fork. I’ll restore the branch and reopen the PR so we can continue the review. |
|
any update on this ? |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add PKCS11 Token Support
Description
This PR adds support for PKCS11 tokens (HSMs) with secp256k1 curve support to HWI. The implementation allows users to use PKCS11-compliant hardware security modules as Bitcoin hardware wallets.
Changes Made
hwilib/devices/pkcs11.pytest/test_pkcs11.pytest/run_tests.pyto include PKCS11 testsFeatures
Testing
To run the tests:
Usage
Dependencies
Related Issues
Closes #774