Remove opt-in RBF#936
Open
polespinasa wants to merge 1 commit into
Open
Conversation
Remove the option to signal or not signal for BIP 125 (Opt-in Full Replace-By-Fee). By removing the option in the GUI it will fallback to the wallet configuration which by default is true unless the user changed it using CLI.
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process. |
sedited
reviewed
May 11, 2026
| // append RBF message according to transaction's signalling | ||
| question_string.append("<span style='font-size:10pt; font-weight:normal;'>"); | ||
| if (ui->optInRBF->isChecked()) { | ||
| question_string.append(tr("You can increase the fee later (signals Replace-By-Fee, BIP-125).")); |
Contributor
There was a problem hiding this comment.
Might be good to keep the "You can increase the fee later" string?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the whole network mostly running with Full Replace By Fee, it does not make sense to let the user signal or not to signal for RBF on their transactions.
With this PR the transactions created using the GUI will fallback to the wallet configuration in order to signal or not to signal BIP 125. (True by default).