Conversation
|
ooh concept ack nice! |
81e7db6 to
604eb15
Compare
|
ping @mplsgrant: I can't understand why the namespace test should fail with these changes (although, I don't totally understand the test that well). If you get a minute, would appreciate your eyes on it :) (p.s. it still fails even if I drop the commit touching the namespace deploy code...) |
|
@willcl-ark It looks like it's deploying ingress regardless of whether there is an ingress flag enabled. Our Service Accounts (like bob) can't |
|
I should also add that the namespace_admin.py test actually runs the entire scenarios_test.py. |
604eb15 to
a51814d
Compare
|
TODO:
|
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones: If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
a51814d to
5c18af9
Compare
|
undrafted to see if that will make CI work... |
pinheadmz
left a comment
There was a problem hiding this comment.
tested ACK, its fast! tytyty
Deploy everything everywhere, all at once (except fork observer).
Fork observer uses k8s api (via
get_mission()) to create its config, so it has to wait until at least that deploy is finished.