BIP129: add requirements header#2019
Merged
murchandamus merged 1 commit intobitcoin:masterfrom Feb 27, 2026
Merged
Conversation
Member
Author
jonatack
added
Proposed BIP modification
Member
Author
|
(Is BIP 322 still required? Is this BIP still relevant?) |
Member
|
This PR will need a rebase. |
jonatack
force-pushed
the
2025-10-bip129-requirements
branch
from
790c2ee to
3460230
Compare
Member
Author
Thanks, done. |
| Type: Specification | ||
| Assigned: 2020-11-10 | ||
| License: BSD-2-Clause | ||
| Requires: 32, 174, 322, 380, 381, 382, 383 |
Member
There was a problem hiding this comment.
I would prefer if @hugohn, @nvk, or another author signed off on this, but given that all of these BIPs are explicitly mentioned (BIP 174 in the Motivation, and it seems that the Roles refer to the PSBT roles [although they use Coordinator instead of Creator?] and the rest explicitly under Prerequisites), this change seems pretty uncontroversial to me.
Member
murchandamus
left a comment
murchandamus
left a comment
There was a problem hiding this comment.
Looking over this again, this seems fine.
jonatack
removed
the
Pending acceptance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BIP 129 requires several prerequisite BIPs, so state them in a "Requires" header.