Kyoto: Remove connection requirement to send tx#202
Merged
tvpeter merged 1 commit intobitcoindevkit:masterfrom Jun 18, 2025
Merged
Kyoto: Remove connection requirement to send tx#202tvpeter merged 1 commit intobitcoindevkit:masterfrom
tvpeter merged 1 commit intobitcoindevkit:masterfrom
Conversation
rustaceanrob
force-pushed
the
kyoto-broadcast-6-17
branch
from
bab0d8b to
6ca7372
Compare
Pull Request Test Coverage Report for Build 15730343098Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 15707490095Details
💛 - Coveralls |
tvpeter
reviewed
Jun 18, 2025
Kyoto now holds on to a transaction internally until it is successfully broadcast, so we can broadcast the transaction immediately once the node starts up, and wait for a confirmation or 30 second timeout
rustaceanrob
force-pushed
the
kyoto-broadcast-6-17
branch
from
6ca7372 to
3b60b7b
Compare
Contributor
Author
|
Updated the error message as well as the irrelevant tracing message |
Collaborator
|
Thank you @rustaceanrob |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kyoto now holds on to a transaction internally until it is successfully broadcast, so we can broadcast the transaction immediately once the node starts up, and wait for a confirmation or 30 second timeout
Successful test on Signet. Note that
Testnet4still has the difficulty adjustment bug when loading block headers from storage.Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
CHANGELOG.mdBugfixes: