doc: added prerequisites to readme#221
Closed
RockRockX2 wants to merge 1 commit intobitcoindevkit:masterfrom
Closed
doc: added prerequisites to readme#221RockRockX2 wants to merge 1 commit intobitcoindevkit:masterfrom
RockRockX2 wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
notmandatory
requested changes
Sep 30, 2025
Member
notmandatory
left a comment
notmandatory
left a comment
There was a problem hiding this comment.
Thanks for the suggestion that will be helpful to new devs who haven't already installed gcc.
README.md
Outdated
| #### Prerequisites | ||
|
|
||
| Building BDK requires gcc. If you do not have this installed run: | ||
| ```` shell |
Member
There was a problem hiding this comment.
⛏️ needs to be three back-ticks and no space after.
Suggested change
| ```` shell | |
| ```shell |
Member
There was a problem hiding this comment.
This sub-section should also be placed at the beginning of the "Install bdk-cli" section.
Pull Request Test Coverage Report for Build 18167582568Details
💛 - Coveralls |
tvpeter
approved these changes
Oct 11, 2025
aagbotemi
reviewed
Oct 16, 2025
aagbotemi
left a comment
aagbotemi
left a comment
There was a problem hiding this comment.
Good job @RockRockX2, I left a suggestion for you to check.
| Building BDK requires gcc. If you do not have this installed run: | ||
| ``` shell | ||
| sudo apt-get install build-essential | ||
| ```` |
There was a problem hiding this comment.
It should be three back-ticks to close the code block.
Collaborator
There was a problem hiding this comment.
@RockRockX2, are you still available to fix this comment?
3 tasks
Collaborator
|
This PR is closed in favour of #246 because the contributor was unresponsive. |
tvpeter
added a commit
that referenced
this pull request
Mar 10, 2026
0725724 docs: Update stated bdk_wallet version (Vihiga Tyonum) d787fa0 doc: added prerequisites to readme (oscar) Pull request description: <!-- You can erase any parts of this template not applicable to your Pull Request. --> ### Description This is a continuation of #221 <!-- Describe the purpose of this PR, what's being adding and/or fixed --> ### Notes to the reviewers <!-- In this section you can include notes directed to the reviewers, like explaining why some parts of the PR were done in a specific way --> - Update the stated `bdk_wallet` to 2.x.x - Addressed review comments on #221 ## Changelog notice <!-- Notice the release manager should include in the release tag message changelog --> <!-- See https://keepachangelog.com/en/1.0.0/ for examples --> ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk-cli/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing ACKs for top commit: notmandatory: ACK 0725724 Tree-SHA512: a0446a915c8c2553ea4612d9e2382e8d3212c73929be9944c9cb965f0fbf2620df339d3284796cf7315bdb65ca5a364a299ba8bfacb3edd3694c2bd796b0fae0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added gcc as a prerequisite.