Conversation
JaskRendix
commented
Jan 18, 2024
JaskRendix
commented
Jan 18, 2024
JaskRendix
commented
Jan 18, 2024
JaskRendix
force-pushed
the
typehints
branch
6 times, most recently
from
15849af to
320de11
Compare
JaskRendix
force-pushed
the
typehints
branch
7 times, most recently
from
2c45582 to
a41a47c
Compare
JaskRendix
force-pushed
the
typehints
branch
from
a41a47c to
d574e09
Compare
JaskRendix
force-pushed
the
typehints
branch
5 times, most recently
from
8ed7fc9 to
278e9fe
Compare
JaskRendix
force-pushed
the
typehints
branch
8 times, most recently
from
4a8610b to
c459b4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR streamlines the codebase by reducing unnecessary type hints. It also addresses a previously broken benchmarking routine:
.run()was not being invoked, resulting in maps not rendering as intended during stress tests. The benchmark loop now correctly displays all TMX maps in sequence, allowing proper visual validation of rendering behavior.