Optimize decode_gid with flag caching + Add tests and benchmark#190
Closed
JaskRendix wants to merge 1 commit intobitcraft:masterfrom
Closed
Optimize decode_gid with flag caching + Add tests and benchmark#190JaskRendix wants to merge 1 commit intobitcraft:masterfrom
decode_gid with flag caching + Add tests and benchmark#190JaskRendix wants to merge 1 commit intobitcraft:masterfrom
Conversation
|
Out of curiosity did you profile/time this at any point? |
b06264c to
1873265
Compare
4e4be5c to
d1d2726
Compare
ad0f329 to
3847c1d
Compare
decode_gid with flag caching + Add tests and benchmark
3847c1d to
0f5f521
Compare
0f5f521 to
f1b60fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR introduces a performance enhancement to
decode_gid, improves test coverage, and adds a lightweight benchmark script to measure decoding speed at scale.Changes included:
decode_gidto use a flag cache: avoids redundantTileFlagsinstantiations for repeated GIDs and preserves identical behavior while improving speedunpack_gidsrobustness against empty, malformed, and truncated inputBenchmarks
bench_decode_gid.pyBenchmarks decoding performance with and without caching:
bench_tmx_maps.pyBenchmarks actual TMX map parsing using files in
/apps/data/: