Improve pytmx Pygame Loader, Unit Test and Cleaner Typing#197
Closed
JaskRendix wants to merge 1 commit intobitcraft:masterfrom
Closed
Improve pytmx Pygame Loader, Unit Test and Cleaner Typing#197JaskRendix wants to merge 1 commit intobitcraft:masterfrom
pytmx Pygame Loader, Unit Test and Cleaner Typing#197JaskRendix wants to merge 1 commit intobitcraft:masterfrom
Conversation
40117e6 to
c484353
Compare
7e3c972 to
89756ba
Compare
pytmx Pygame Loader, Unit Test and Cleaner Typing
|
I've forked the project and uploaded to pypi as pytmx-ng, I'd love to have your code in there, can you open a pull request here: https://github.com/pnearing/pytmx-ng ? Thanks, and I hope this helps you. (this goes for your other pull requests too) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a range of improvements:
smart_convertlogic: adds a newpreserve_alpha_flagparameter to optionally retain per-pixel alpha formatting, even when no transparency is detected, replaces manual pixel counting with the shared helper functionhas_transparency()for cleaner and more consistent transparency detection, introducescount_colorkey_pixels()to estimate colorkey coverage, deciding more intelligently when to applyRLEACCEL, and strengthens fallback behavior when mask operations failpreserve_alpha_flagflag allows external tools or workflows to retain original surface format when alpha is present but not visibly usedsimplify()function for more efficient geometry handling