Open
Conversation
✅ Deploy Preview for biter777countries ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ccoVeille
reviewed
Sep 11, 2024
ccoVeille
left a comment
ccoVeille
left a comment
There was a problem hiding this comment.
While I understand the need to update, I feel strange existing constant are nuked
If they were kept with a deprecated comment, and assigned to the new one with the switch
Author
|
Ah didnt realise this was an option, will update |
RJKeevil
force-pushed
the
lu-subdivision
branch
from
47c3130 to
b3e1b8c
Compare
Author
|
Hi @ccoVeille, i've updated the PR to put the old codes back in. I couldnt see an obvious way to delegate the old codes to the new ones, so at the moment the list is now the superset of both. Let me know if you want somethng different. |
ccoVeille
reviewed
Sep 11, 2024
RJKeevil
force-pushed
the
lu-subdivision
branch
2 times, most recently
from
592980f to
fb055b4
Compare
Author
|
Done, thanks |
ccoVeille
reviewed
Sep 11, 2024
RJKeevil
force-pushed
the
lu-subdivision
branch
from
fb055b4 to
00b60f7
Compare
ccoVeille
approved these changes
Sep 12, 2024
ccoVeille
left a comment
ccoVeille
left a comment
There was a problem hiding this comment.
LGTM 👍
Let's wait for a maintainer feedback now
RJKeevil
force-pushed
the
lu-subdivision
branch
from
00b60f7 to
77fb01d
Compare
Author
|
spotted a duplicate in the case statement, fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as per https://en.wikipedia.org/wiki/ISO_3166-2:LU