-
-
Notifications
You must be signed in to change notification settings - Fork 254
Improve GettingStarted page (#11824) #11826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve GettingStarted page (#11824) #11826
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe GettingStartedPage.razor component has been restructured with updated metadata, reorganized content using card-based layouts, and consolidated instructional sections. The page now uses BitCard components to present installation and configuration steps hierarchically, replacing previous inline content blocks and code examples with summarized messaging. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/GettingStartedPage.razor (1)
31-111: Consider wrapping standalone “Or” lines inBitTextfor consistencyInside the “Install” card’s optional steps accordion (lines 77, 92, 107), the bare
Orstrings are not wrapped inBitText, unlike almost all other text on the page. For typography and spacing consistency, you can wrap them inBitText:- <CodeBox>dotnet add package Bit.BlazorUI.Extras</CodeBox> - - Or - - <CodeBox>Install-Package Bit.BlazorUI.Extras</CodeBox> + <CodeBox>dotnet add package Bit.BlazorUI.Extras</CodeBox> + + <BitText>Or</BitText> + + <CodeBox>Install-Package Bit.BlazorUI.Extras</CodeBox> - <CodeBox>dotnet add package Bit.BlazorUI.Assets</CodeBox> - - Or - - <CodeBox>Install-Package Bit.BlazorUI.Assets</CodeBox> + <CodeBox>dotnet add package Bit.BlazorUI.Assets</CodeBox> + + <BitText>Or</BitText> + + <CodeBox>Install-Package Bit.BlazorUI.Assets</CodeBox> - <CodeBox>dotnet add package Bit.BlazorUI.Icons</CodeBox> - - Or - - <CodeBox>Install-Package Bit.BlazorUI.Icons</CodeBox> + <CodeBox>dotnet add package Bit.BlazorUI.Icons</CodeBox> + + <BitText>Or</BitText> + + <CodeBox>Install-Package Bit.BlazorUI.Icons</CodeBox>This keeps all textual content going through the same component pipeline.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
📒 Files selected for processing (1)
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/GettingStartedPage.razor(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build Bit.BlazorUI
🔇 Additional comments (4)
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/GettingStartedPage.razor (4)
3-10: Centralized BitParams configuration looks goodUsing
_cascadingParamsto push sharedBitCard,BitText, andBitTagdefaults throughBitParamskeeps the layout consistent and reduces repetition on this page.
12-27: Top-level layout and metadata restructuring is clear
PageOutletmetadata plus the new<section class="page-container">andBitParamswrapper give the page a clean, hierarchical structure around the “Getting Started” heading without adding complexity.
115-125: Namespace step is concise and actionableThe “2. Namespace” card clearly points to
_Imports.razorwith an inlineBitTagand a singleCodeBoxline; this is easy to follow and matches typical Blazor conventions.
129-175: Styles & Scripts card reads well and covers optional assets cleanlyThe separation between required CSS/JS and the optional extras/assets/icons in the accordion is clear and keeps the main path simple while still exposing the advanced options.
closes #11824
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.