Fix Payjoin: Add back original PSBT input to payjoin proposal#267
Closed
DanGould wants to merge 3 commits intobitmask-stack:developmentfrom
Closed
Fix Payjoin: Add back original PSBT input to payjoin proposal#267DanGould wants to merge 3 commits intobitmask-stack:developmentfrom
DanGould wants to merge 3 commits intobitmask-stack:developmentfrom
Conversation
Unlike Bitcoin Core's walletprocesspsbt RPC, BKD's finalize_psbt only checks if the script in the PSBT input map matches the descriptor and does not check whether it has control of the OutPoint specified in the unsigned_tx's TxIn. So the original_psbt input data needs to be added back into payjoin_psbt without overwriting receiver input. BIP 78 spec clears script data from payjoin proposal.
cryptoquick
approved these changes
Jul 12, 2023
Member
cryptoquick
left a comment
cryptoquick
left a comment
There was a problem hiding this comment.
Neat! LGTM, we can test this in our next release.
Collaborator
Author
|
I've added
|
DanGould
commented
Jul 12, 2023
DanGould
force-pushed
the
payjoin-fix
branch
2 times, most recently
from
e7188b9 to
de8d8b3
Compare
Member
|
These changes still look fine. If any fixes need to be made, we can do them in a separate PR. I'll be sure to run CI checks on this as well. |
Member
|
I've invited you to the project with write access so your contributions can run in CI more easily. |
Member
|
Looks like there was a linter issue. I'm closing this for #269. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike Bitcoin Core's walletprocesspsbt RPC, BDK's finalize_psbt only checks if the script in the PSBT input map matches the descriptor and does not check whether it has control of the OutPoint specified in the unsigned_tx's TxIn. BIP 78 spec clears script data from payjoin proposal. So the original_psbt input data needs to be added back into payjoin_psbt without overwriting receiver input.
See where we ran into the same problem with BDK-CLI and the proposed solution there.