Correct keymap scrolling, refactor keymap for consistency#170
Open
zambetti wants to merge 6 commits intobjarneo:mainfrom
Open
Correct keymap scrolling, refactor keymap for consistency#170zambetti wants to merge 6 commits intobjarneo:mainfrom
zambetti wants to merge 6 commits intobjarneo:mainfrom
Conversation
…ch style of keymapMaybeAdjustScroll()
zambetti
changed the title
bjarneo
reviewed
Apr 6, 2026
ui/model/keymap.go
Outdated
| m.keymap.cursor = 0 | ||
|
|
||
| case msg.Code == tea.KeyUp: | ||
| case "up", "k": |
Owner
There was a problem hiding this comment.
Can you remove the kjgG? I would be nice to have them, but then you can't write certain characters while searching the keymap.
Contributor
Author
There was a problem hiding this comment.
Makes good sense. I have removed them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects the scrolling behavior in the keymap view so it matches the persistent scrolling used in the playlist and file browser. Introduces a dedicated
scrollstate for the keymap view, ensuring the view only scrolls when the cursor moves outside the visible region. Additionally, there is some refactoring for style consistency with analogous functions of the file browser view.