Skip to content

fix(cmd): preserve non-profiling args correctly. #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wolf31o2 merged 1 commit into from
Dec 8, 2025
Merged

fix(cmd): preserve non-profiling args correctly. #1097

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions cmd/dingo/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ func main() {
// Parse profiling flags before cobra setup (handle both --flag=value and --flag value syntax)
cpuprofile := ""
memprofile := ""
var newArgs []string
args := os.Args
if len(args) > 0 {
args = args[1:] // Skip program name
Expand All @@ -160,8 +161,17 @@ func main() {
case arg == "--memprofile" && i+1 < len(args):
memprofile = args[i+1]
i++ // Skip next arg
default:
// Not a profiling flag, keep it
newArgs = append(newArgs, arg)
}
}
// Reconstruct os.Args with program name (os.Args[0] is never nil in practice, but nilaway doesn't know this)
programName := "dingo"
if len(os.Args) > 0 {
programName = os.Args[0]
}
os.Args = append([]string{programName}, newArgs...)

// Initialize CPU profiling (starts immediately, stops on exit)
if cpuprofile != "" {
Expand Down
Loading