Skip to content

Move Branta send validation toggle into Send modal and remove settings-level flag#879

Draft
Copilot wants to merge 3 commits into
mainfrom
copilot/add-branta-send-validation
Draft

Move Branta send validation toggle into Send modal and remove settings-level flag#879
Copilot wants to merge 3 commits into
mainfrom
copilot/add-branta-send-validation

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 27, 2026

Branta validation opt-in is now controlled directly in the Send popup instead of global Settings. The validation trigger is local to each send attempt, with the checkbox defaulting to off.

  • Problem alignment

    • Users wanted Branta validation enabled/disabled at send time in the popup itself, not as a persisted app setting.
    • Settings-level Branta controls were removed to avoid conflicting sources of truth.
  • Send modal changes

    • Added a small CheckBox (BrantaValidationToggle) to SendFundsModal.axaml.
    • Default state is unchecked.
    • Updated ValidateBrantaAsync() in SendFundsModal.axaml.cs to run Branta validation only when the checkbox is checked.
  • Settings rollback

    • Removed the Branta validation card/toggle from SettingsView.axaml.
    • Removed IsBrantaSendValidationEnabled from SettingsViewModel.cs.
    • Removed persisted Branta setting state from PrototypeSettings in ShellViewModel.cs (load/save/subscription/data contract).
  • Behavioral impact

    • Branta validation is now per-send and explicit.
    • No persisted Branta validation preference remains in app settings.
private async Task<bool> ValidateBrantaAsync()
{
    if (BrantaValidationToggle.IsChecked != true)
    {
        return true;
    }

    var destination = AddressInput.Text?.Trim() ?? "";
    var validation = await BrantaValidationService.ValidateAsync(destination);
    if (validation.IsValid) return true;

    AddressError.Text = validation.ErrorMessage ?? "Address failed Branta validation";
    AddressError.IsVisible = true;
    return false;
}

Copilot AI changed the title Add optional Branta recipient validation to wallet send flow Move Branta send validation toggle into Send modal and remove settings-level flag May 27, 2026
Copilot AI requested a review from dangershony May 27, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants