Skip to content

fix(diff-viewer): reset comment editor scroll on comment change #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matt2e merged 1 commit into from
May 18, 2026
Merged

fix(diff-viewer): reset comment editor scroll on comment change #736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/diff-viewer/src/lib/components/CommentEditor.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,15 @@

// Track current input value - initialized by effect when existingComment changes
let currentValue = $state('');
let textareaEl: HTMLTextAreaElement | null = null;

// Update value when existingComment changes (for editing mode)
// Update value when existingComment changes (for editing mode). Reset scroll
// on identity change so a previously-scrolled textarea doesn't leak its
// offset into the next comment being viewed.
$effect(() => {
existingComment?.id;
currentValue = existingComment?.content ?? '';
if (textareaEl) textareaEl.scrollTop = 0;
});

function handleInput(e: Event) {
Expand Down Expand Up @@ -107,6 +112,7 @@
style="top: {top}px; left: {left}px; width: {width}px;"
>
<textarea
bind:this={textareaEl}
class="comment-textarea"
{placeholder}
value={currentValue}
Expand Down